Repository navigation
Conversation
A release that GITHUB_TOKEN creates does not start a new workflow run, so the `release: published` trigger alone would never fire for a release the repository makes for itself. The tag is the event that always exists: a maintainer pushes it, and any other producer of the release pushes it too. Resolve the tag from the most specific event data first, then fall back to the pushed ref, so the release, manual, and tag triggers all keep working. Change-Id: I65cb73662f3c7849d320a7c9885dbfff8ef79774
A release now makes itself: a maintainer pushes an annotated or lightweight version tag, and the workflow creates the GitHub release with generated notes. Before this, the release was a manual step in the GitHub UI, so the tag and its release could drift apart. Create the release only when it does not exist yet, so a re-run of the workflow does not fail on the tag that already has a release. Change-Id: Id820c7ca6ea029036a14dda06e258ad9470bd980
A release with no binaries is not a release that a maintainer can hand to a user who does not build from source. Build Linux and macOS binaries for arm64 and amd64, then attach them with checksums. The assets go to a draft first, so a release that still lacks an asset does not appear in the public list while the upload runs. The publish job has no checkout, so it sets GH_REPO: gh reads the repository from the environment, and a job without a work tree has nothing else to read. A re-run must repair a release that a failed upload left behind, so the upload step has no condition and overwrites its assets. The create and the publish steps read the release state first, so a re-run does not publish twice and does not touch a version that is already public. Change-Id: I81af424ff328bbe5a33ab29fa976485cdf40671a
The worktree tooling asks for `latest`, but `mise.lock` still held 0.21.0, so every run used the older release. The lock now records the current release. Change-Id: If0ce9f775764c099ed435bfbbadca0c15b9ea301
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.